szetszwo commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1757338835
##########
hadoop-ozone/ozone-manager/dev-support/findbugsExcludeFile.xml:
##########
@@ -89,4 +89,9 @@
<Class
name="org.apache.hadoop.ozone.om.upgrade.TestOMLayoutFeatureAspect"/>
<Bug pattern="BC_IMPOSSIBLE_CAST" />
</Match>
+ <Match>
+ <Class name="org.apache.hadoop.ozone.om.ratis.OzoneManagerDoubleBuffer" />
+ <Field name="readyBuffer" />
+ <Bug pattern="IS2_INCONSISTENT_SYNC" />
+ </Match>
Review Comment:
The `splitReadyBufferAtCreateSnapshot()` just has a simple loop. Adding
`synchronized ` won't affect the performance On the other hand, suppressing
`IS2_INCONSISTENT_SYNC` will hide the real bug in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
