adoroszlai commented on PR #7129: URL: https://github.com/apache/ozone/pull/7129#issuecomment-2347934320
> I don't understand ..., it claims to be a general framework to disable OM features but it is actually just a feature flag for key rewrite. You are right, the title should have been more specific (mentioning key rewrite). > From the config perspective it is worse than a feature flag, because one needs to manually inspect the code to see if the feature they want to disable is even supported if they configure it. It is intentionally undocumented, because the restriction is not implemented for other existing features. > It seems this was done because there is a stigma around adding feature flags, but one had to be added so it was given a more generic name and implementation. That impression is wrong. It was done this way to avoid the proliferation of config properties when a single config property is enough for the same. However, I do not have time to implement it for every other feature. Folks are free to use this to control the feature they work(ed) on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
