jianghuazhu commented on code in PR #7191:
URL: https://github.com/apache/ozone/pull/7191#discussion_r1758260911
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationSupervisor.java:
##########
@@ -240,6 +242,7 @@ public void addTask(AbstractReplicationTask task) {
failureCounter.put(task.getMetricName(), new AtomicLong(0));
timeoutCounter.put(task.getMetricName(), new AtomicLong(0));
skippedCounter.put(task.getMetricName(), new AtomicLong(0));
+ requestTotalTime.put(task.getMetricName(), new AtomicLong(0));
Review Comment:
Thanks @errose28 for the comment and review.
I will update it later.
Right now, taskCounter records the number of queues.
```
private final Map<Class<?>, AtomicInteger> taskCounter =
new ConcurrentHashMap<>();
```
I will add the QueueCount metric to ReplicationSupervisorMetrics later.
In addition, I suggest improving taskCounter so that it is consistent with
requestCounter and successCounter.
```
private final Map<String, AtomicLong> taskCounter = new
ConcurrentHashMap<>();
```
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
