slfan1989 commented on code in PR #6960:
URL: https://github.com/apache/ozone/pull/6960#discussion_r1761175565
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:
##########
@@ -508,6 +512,18 @@ private boolean updateDnsToUuidMap(
return ipChanged || hostNameChanged;
}
+ /**
+ * Check if the version has been updated.
+ *
+ * @param oldVersion datanode oldVersion
+ * @param newVersion datanode newVersion
+ * @return true means replacement is needed, while false means replacement
is not needed.
+ */
+ private boolean isVersionChange(String oldVersion, String newVersion) {
+ final boolean ipChanged = !Objects.equals(oldVersion, newVersion);
+ return ipChanged;
+ }
Review Comment:
I agree with and understand your idea, but I would still like to push for
this change to be included in this PR, as the modification involved is quite
minimal.
In this PR, we have added the functionality to display the DN version.
Currently, the issue we are facing is that SCM, after startup, will no longer
accept updates to the DN compilation version, even if the DN's compilation
version has been updated and restarted.
We have added some logic to check whether the DN compilation version has
changed. If it has, the heartbeat will update the DN version in SCM's memory.
There are some issues with my variable naming, and I will work on improving
this part of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
