swamirishi commented on code in PR #7193:
URL: https://github.com/apache/ozone/pull/7193#discussion_r1767775721
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1379,6 +1379,8 @@ message PurgeKeysRequest {
// if set, will purge keys in a snapshot DB instead of active DB
optional string snapshotTableKey = 2;
repeated SnapshotMoveKeyInfos keysToUpdate = 3;
+ // previous snapshotID can also be null & this field would be absent in
older requests.
+ optional NullableUUID expectedPreviousSnapshotID = 4;
Review Comment:
I want to pass expectedPreviousSnapshotID = null for the case there are no
snapshots in the chain. But older requests might not have a
expectedPreviousSnapshotID in the request, so this validation could incorrectly
run for the older requests leading to inconsistencies in the OM db on replays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
