hemantk-12 commented on code in PR #7200:
URL: https://github.com/apache/ozone/pull/7200#discussion_r1768830266
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java:
##########
@@ -686,12 +686,25 @@ private <V, R> List<Table.KeyValue<String, R>>
getTableEntries(String startKey,
return entries;
}
+ private Optional<String> getBucketPrefix(String volumeName, String
bucketName, boolean isFSO) throws IOException {
+ // Bucket prefix would be empty if both volume & bucket is empty i.e.
either null or "".
+ if (StringUtils.isEmpty(volumeName) && StringUtils.isEmpty(bucketName)) {
+ return Optional.empty();
+ } else if (StringUtils.isEmpty(bucketName) ||
StringUtils.isEmpty(volumeName)) {
+ throw new IOException("One of volume : " + volumeName + ", bucket: " +
bucketName + " is empty." +
+ " Either both should be empty or none of the arguments should be
empty");
+ }
+ if (StringUtils.isEmpty(bucketName)) {
+ bucketName = "";
+ }
Review Comment:
Isn't this covered by line 693?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
