whbing commented on code in PR #7016:
URL: https://github.com/apache/ozone/pull/7016#discussion_r1773206688
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocolPB/StorageContainerLocationProtocolClientSideTranslatorPB.java:
##########
@@ -157,6 +158,12 @@ public final class
StorageContainerLocationProtocolClientSideTranslatorPB
private final StorageContainerLocationProtocolPB rpcProxy;
private final SCMContainerLocationFailoverProxyProvider fpp;
+ /**
+ * This is used to check if 'leader' or 'follower' exists,
+ * in order to confirm whether we have enabled Ratis.
+ */
+ private final List<String> scmRatisRolesToCheck = Arrays.asList("leader",
"follower");
Review Comment:
The variable `scmRatisRolesToCheck` is only referenced in one place, and I'm
not sure if defining it as a global variable is a good idea. Additionally, from
my understanding, using `static` might be better if it needs to be used.
@ChenSammi Please help give some suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
