myskov commented on code in PR #7234:
URL: https://github.com/apache/ozone/pull/7234#discussion_r1774724440
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeInfo.java:
##########
@@ -46,15 +46,15 @@
* - fsCapacity: reported total capacity from local fs.
* - minVolumeFreeSpace (mvfs) : determines the free space for closing
containers.This is like adding a few reserved bytes to reserved space.
- Dn's will send close container action to SCM at this limit & it is
+ Dn's will send close container action to SCM at this limit & it is
configurable.
*
*
* |----used----| (avail) |++mvfs++|++++reserved+++++++|
- * |<- capacity ->|
+ * |<- capacity ->|
Review Comment:
it seems <pre> should be used for the table and tables below
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java:
##########
@@ -439,13 +439,13 @@ public static boolean isSameSchemaVersion(String schema,
String other) {
/**
* Moves container directory to a new location
- * under "<volume>/hdds/<cluster-id>/tmp/deleted-containers"
+ * under "<volume>/hdds/<cluster-id>/tmp/deleted-containers"
Review Comment:
```suggestion
* under "volume/hdds/cluster-id/tmp/deleted-containers"
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeUsage.java:
##########
@@ -78,9 +78,10 @@ public long getUsedSpace() {
/**
* Calculate available space use method B.
+ * <pre>
* |----used----| (avail) |++++++++reserved++++++++|
* | fsAvail |-------other-------|
- * ->|~~~~|<-
+ * ->|~~~~|<- </pre>
Review Comment:
```suggestion
* ->|~~~~|<-
* </pre>
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeUsage.java:
##########
@@ -80,7 +80,7 @@ public long getUsedSpace() {
* Calculate available space use method B.
* |----used----| (avail) |++++++++reserved++++++++|
* | fsAvail |-------other-------|
- * ->|~~~~|<-
+ * ->|~~~~|<-
Review Comment:
let's use `<pre>`
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/ProfileServlet.java:
##########
@@ -79,7 +79,7 @@
* curl "http://localhost:10002/prof";
* - To collect 1 minute CPU profile of current process and output in tree
* format (html)
- * curl "http://localhost:10002/prof?output=tree&duration=60";
+ * curl {@literal "http://localhost:10002/prof?output=tree&duration=60"}
Review Comment:
I think it's better to use `pre` block for the whole comment
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/ozone/audit/package-info.java:
##########
@@ -48,7 +48,7 @@
* This interface must be implemented by entities requiring audit logging.
* For example - OMVolumeArgs, OMBucketArgs.
* The implementing class must override toAuditMap() to return an
- * instance of Map<Key, Value> where both Key and Value are String.
+ * instance of Map<Key, Value> where both Key and Value are String.
Review Comment:
```suggestion
* instance of {@code Map<Key, Value>} where both Key and Value are String.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
