[
https://issues.apache.org/jira/browse/HDDS-11387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887488#comment-17887488
]
Siddhant Sangwan edited comment on HDDS-11387 at 10/8/24 6:34 AM:
------------------------------------------------------------------
[~a.juncevich] Yes, it's probably best to just fix the bugs ASAP at this point
without bothering about the feature flag.
{quote}do yo have any idea about how and when we can understand that feature is
ready and properly tested?
{quote}
I agree that many bugs aren't found until people actually start using the
feature. I'd call something ready for use when there is enough unit and
integration testing in place. And for a CLI command, a decent amount of manual
testing as well!
was (Author: siddhant):
[~a.juncevich] Yes, it's probably best to just fix the bugs ASAP at this point
without bothering about the feature flag.
bq. do yo have any idea about how and when we can understand that feature is
ready and properly tested?
I agree that many bugs aren't found until people actually start using the
feature. I'd call something ready for use when there is enough unit and
integration testing in place.
> Put the changes introduced in HDDS-11120 behind a feature flag
> --------------------------------------------------------------
>
> Key: HDDS-11387
> URL: https://issues.apache.org/jira/browse/HDDS-11387
> Project: Apache Ozone
> Issue Type: Bug
> Components: Balancer, Ozone CLI, SCM
> Affects Versions: 2.0.0
> Reporter: Siddhant Sangwan
> Priority: Major
>
> The goal here is to protect existing users of the Container Balancer Status
> command from bugs introduced in HDDS-11120. We can have a verbose flag in the
> command `{{ozone admin containerbalancer status}}` to use the new code and
> return the new output, and without the flag it returns the old output. Once
> the new feature is more reliable and well tested, we can make it the default.
> On the other hand, if every useful feature is put behind a flag, it'll be
> hard to discover new and useful information. We need to decide whether we
> want a verbose flag, a new command for the new code and output, or just fix
> bugs in the new code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]