ArafatKhan2198 commented on PR #6969:
URL: https://github.com/apache/ozone/pull/6969#issuecomment-2404554827
Thanks for the review @devmadhuu @sumitagrawl @devabhishekpal please
consider the latest commit having the final changes as discussed offline
In the latest commit, we made significant improvements to the search
functionality for deleted keys:
- Unified Search Logic: The search logic has been refactored and moved to
OMDBInsightEndpoint. This ensures that both cases (with and without
startPrefix) are handled by the same method, simplifying the code.
- Pagination Handling: We refined the logic to ensure accurate pagination in
all scenarios. Now, searches correctly handle the `prevKey` and return the
appropriate records, whether a `startPrefix` is provided or not.
- Expanded Unit Testing: Added new unit tests in TestOmDBInsightEndPoint and
TestDeletedKeysSearchEndpoint to cover the four key search scenarios:
- `prevKey` provided, `startPrefix` empty.
- `prevKey` empty, `startPrefix` empty.
- `startPrefix` provided, `prevKey` empty.
- `startPrefix` provided, `prevKey` provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
