[
https://issues.apache.org/jira/browse/HDDS-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888984#comment-17888984
]
Scolley Huang commented on HDDS-10240:
--------------------------------------
[~duongnguyen]
As I'm working on removing the flag {{{}"ozone.ec.grpc.zerocopy.enabled"{}}},
I've come across its usage in a couple of places:
1. in AbstractTestECKeyOutputStream:
{code:java}
/**
* Create a MiniDFSCluster for testing.
*/
protected static void init(boolean zeroCopyEnabled) throws Exception {
chunkSize = 1024 * 1024;
flushSize = 2 * chunkSize;
maxFlushSize = 2 * flushSize;
blockSize = 2 * maxFlushSize; {code}
or
2. in GrpcXceiverService.java:
{code:java}
public GrpcXceiverService(ContainerDispatcher dispatcher,
boolean zeroCopyEnabled) {
this.dispatcher = dispatcher;
} {code}
should i remove all boolean that use zeroCopyEnabled and its associated logic
in these sections or just flag {{"ozone.ec.grpc.zerocopy.enabled" ?}}
> Cleanup zero-copy EC
> --------------------
>
> Key: HDDS-10240
> URL: https://issues.apache.org/jira/browse/HDDS-10240
> Project: Apache Ozone
> Issue Type: Bug
> Reporter: Duong
> Assignee: Scolley Huang
> Priority: Major
>
> * Remove the flag "ozone.ec.grpc.zerocopy.enabled", always have zero-copy
> enabled.
> * Use `release` instead of `popStream`
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]