kerneltime commented on code in PR #6613:
URL: https://github.com/apache/ozone/pull/6613#discussion_r1802072873


##########
hadoop-hdds/client/dev-support/findbugsExcludeFile.xml:
##########
@@ -32,4 +32,8 @@
     <Class 
name="org.apache.hadoop.hdds.scm.storage.TestBlockInputStream"></Class>
     <Bug pattern="RR_NOT_CHECKED" />
   </Match>
+  <Match>
+    <Class 
name="org.apache.hadoop.hdds.scm.storage.TestStreamBlockInput"></Class>
+    <Bug pattern="RR_NOT_CHECKED" />
+  </Match>

Review Comment:
   This applies to all the places in the code; validate the returned number of 
bytes read with the expected number of bytes read, and drop the find bugs 
exception added. Also commented below for the test itself



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to