adoroszlai commented on code in PR #7155:
URL: https://github.com/apache/ozone/pull/7155#discussion_r1804310374
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionManager.java:
##########
@@ -398,10 +398,12 @@ private synchronized boolean
checkIfDecommissionPossible(List<DatanodeDetails> d
if (opState != NodeOperationalState.IN_SERVICE) {
numDecom--;
validDns.remove(dn);
+ LOG.warn("Cannot decommission {} because it is not IN-SERVICE",
dn.getHostName());
Review Comment:
I think this message (and similar one for maintenance) could be improved by
including the actual `opState` the node is in.
Also, please consider replacing `dn.getHostName()` with `dn` to rely on:
https://github.com/apache/ozone/blob/f784a84a04bbabde01f3154d24a1eb92344088d1/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java#L561-L563
This shows just a bit more info to make the node uniquely identifiable while
keeping the hostname for convenience. (Applies to all similar logs.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
