szetszwo commented on PR #6825:
URL: https://github.com/apache/ozone/pull/6825#issuecomment-2419935546
@jojochuang , thanks for working on this! Sorry that I missed this pr
earlier. The change looks good. Some minor suggestions
- It is better to not building the intermediate protos since it may lead to
more buffer copying.
- Combine the short lines.
```java
} else if (proto.getCmdType() == Type.Echo) {
final EchoRequestProto echo = proto.getEcho();
// skipping the payload field so it doesn't get written to the ratis
log
protoBuilder.setEcho(EchoRequestProto.newBuilder(echo).clearPayload()).build();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
