jianghuazhu commented on PR #7317: URL: https://github.com/apache/ozone/pull/7317#issuecomment-2419960324
Thanks @adoroszlai for the comment and review. Because the default DEFAULT_PACKAGE has been defined in RequestValidations, and the DEFAULT_PACKAGE has been assigned by default in RequestValidations#validationsPackageName. Therefore, I think it is not necessary to define the same value in OzoneManagerProtocolServerSideTranslatorPB, which seems a bit redundant. ``` ...... private static final String DEFAULT_PACKAGE = "org.apache.hadoop.ozone"; private String validationsPackageName = DEFAULT_PACKAGE; ...... ``` If it is for security reasons, I think it is okay not to modify it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
