adoroszlai commented on code in PR #6856:
URL: https://github.com/apache/ozone/pull/6856#discussion_r1805240909
##########
hadoop-ozone/common/src/main/resources/ozone-version-info.properties:
##########
@@ -19,9 +19,6 @@
version=${declared.ozone.version}
release=${ozone.release}
revision=${version-info.scm.commit}
-branch=${version-info.scm.branch}
-user=${user.name}
-date=${version-info.build.time}
url=${version-info.scm.uri}
Review Comment:
You are right, we may need to remove `url` eventually. For the current
check it's OK, rebuild happens in the same repo.
Commit ID is worth including even if it causes jar to be different after
e.g. commit+revert. I think that carries some information.
https://reproducible-builds.org/docs/version-information/
> is there a CI run where the repro check reported the jars causing
discrepancy
Yes, I linked to such a run in my previous comment:
https://github.com/adoroszlai/ozone/actions/runs/11312548693/job/31460267951
Here `hdds-common-2.0.0-SNAPSHOT.jar` is not the same due to difference in
`hdds-version-info.properties`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
