szetszwo commented on code in PR #7109:
URL: https://github.com/apache/ozone/pull/7109#discussion_r1805087293
##########
hadoop-hdds/interface-server/src/main/proto/ScmServerDatanodeHeartbeatProtocol.proto:
##########
@@ -177,19 +177,21 @@ message StorageReportProto {
optional uint64 capacity = 3 [default = 0];
optional uint64 scmUsed = 4 [default = 0];
optional uint64 remaining = 5 [default = 0];
- optional StorageTypeProto storageType = 6 [default = DISK];
+ optional StorageTypeProto storageType = 6 [default = DISK, deprecated =
true];
Review Comment:
It seems to be safe to just replace `StorageTypeProto` with
`Hdds.StorageTypeProto`.
- See
https://stackoverflow.com/questions/68239684/protobuf-is-it-backward-compatible-to-move-message-to-imported-file
We should test it.
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -294,6 +294,14 @@ enum ReplicationFactor {
ZERO = 0; // Invalid Factor
}
+enum StorageType {
Review Comment:
To avoid confusing with `org.apache.hadoop.hdds.protocol.StorageType`, let's
use `StorageTypeProto`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
