adoroszlai opened a new pull request, #7342:
URL: https://github.com/apache/ozone/pull/7342

   ## What changes were proposed in this pull request?
   
   Fix intermittent 
[failure](https://github.com/apache/ozone/actions/runs/11442330586/job/31839199387?pr=7340#step:10:35)
 in `repro` check:
   
   ```
   --- 
/home/runner/.m2/repository/org/apache/ozone/ozone-manager/2.0.0-SNAPSHOT/ozone-manager-2.0.0-SNAPSHOT.jar
   +++ hadoop-ozone/ozone-manager/target/ozone-manager-2.0.0-SNAPSHOT.jar
   ...
   ├── builddef.lst
   │┄ ordering differences only
   ```
   
   caused by:
   
   > aspectj-maven-plugin generates a builddef.lst file with the detailed 
options passed to AspectJ and this file is embedded in the final jar. 
([source](https://github.com/mojohaus/aspectj-maven-plugin/issues/52))
   
   The contents of `builddef.lst` is non-reproducible due to:
   
   - order of arguments may be different between runs (depends on filesystem 
iteration)
   - arguments contain absolute paths
   
   Since this file is not required at runtime, we should exclude it from the 
jar, which is made possible by 
https://github.com/dev-aspectj/aspectj-maven-plugin/commit/b4c9a8ce61eeafd2c2fe985a90eeedec61c80a59
   
   https://issues.apache.org/jira/browse/HDDS-11600
   
   ## How was this patch tested?
   
   Verified that `builddef.lst` is no longer part of the jar:
   
   ```
   $ unzip -t 
hadoop-ozone/dist/target/ozone-2.0.0-SNAPSHOT/share/ozone/lib/ozone-manager-2.0.0-SNAPSHOT.jar
 | grep -c builddef.lst
   0
   
   $ find . -name builddef.lst
   ./hadoop-ozone/ozone-manager/target/aspectj-build/builddef.lst
   ```
   
   Regular CI:
   https://github.com/adoroszlai/ozone/actions/runs/11455208945


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to