ArafatKhan2198 commented on code in PR #7327:
URL: https://github.com/apache/ozone/pull/7327#discussion_r1810723652
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/app.tsx:
##########
@@ -70,7 +71,7 @@ class App extends React.Component<Record<string, object>,
IAppState> {
<Layout className={layoutClass}>
<Header>
Review Comment:
If we move to the old insights page and click on the UI change button we get
en empty page
<img width="953" alt="image"
src="https://github.com/user-attachments/assets/89b4643a-7f10-4cc1-a79d-1ca285e6b1b6";>
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/routes-v2.tsx:
##########
@@ -53,5 +55,13 @@ export const routesV2 = [
{
path: '/Containers',
component: Containers
+ },
Review Comment:
And also the View Insights page in the overview page does not route us to
the Insights page.
<img width="1160" alt="image"
src="https://github.com/user-attachments/assets/d18f17ea-7f1c-428f-b876-6dea3f69cdb9";>
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/components/tables/insights/deletePendingKeysTable.tsx:
##########
@@ -0,0 +1,194 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one
+* or more contributor license agreements. See the NOTICE file
+* distributed with this work for additional information
+* regarding copyright ownership. The ASF licenses this file
+* to you under the Apache License, Version 2.0 (the
+* "License"); you may not use this file except in compliance
+* with the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+import React from 'react';
+import { AxiosError } from 'axios';
+import Table, {
+ ColumnsType,
+ TablePaginationConfig
+} from 'antd/es/table';
+import { ValueType } from 'react-select';
+
+import Search from '@/v2/components/search/search';
+import SingleSelect, { Option } from '@/v2/components/select/singleSelect';
+import ExpandedPendingKeysTable from
'@/v2/components/tables/insights/expandedPendingKeysTable';
Review Comment:
When I first accessed the Insights page and clicked on the "Keys Pending for
Deletion" tab, I encountered an error pop-up. However, this issue occurs only
with this specific tab, not the others.
<img width="2058" alt="image"
src="https://github.com/user-attachments/assets/b0cdd322-4262-4ad4-91f5-5b0efc6ddf3f";>
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/components/tables/insights/deletePendingKeysTable.tsx:
##########
@@ -0,0 +1,194 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one
+* or more contributor license agreements. See the NOTICE file
+* distributed with this work for additional information
+* regarding copyright ownership. The ASF licenses this file
+* to you under the Apache License, Version 2.0 (the
+* "License"); you may not use this file except in compliance
+* with the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+import React from 'react';
Review Comment:
While attempting to create keys pending deletion, I noticed data
duplication. For example, in the old UI, when you click the plus icon to expand
and view details about a deleted key, the record displays correctly.
<img width="1161" alt="image"
src="https://github.com/user-attachments/assets/b867a8f1-4f85-4b38-8945-ee868e62cedf";>
However, in the new UI, the same record appears duplicated multiple times.
Interestingly, this duplication does not occur in Safari when accessing the
same link. Should we address this issue, or could it simply be related to a
browser cache problem on my end?
<img width="1160" alt="image"
src="https://github.com/user-attachments/assets/cd16cd1e-560d-4a9e-a235-c658bb5a4be9";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
