adoroszlai commented on code in PR #7349:
URL: https://github.com/apache/ozone/pull/7349#discussion_r1812285807
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java:
##########
@@ -77,20 +80,21 @@ public class DirectoryDeletingService extends
AbstractKeyDeletingService {
// Use only a single thread for DirDeletion. Multiple threads would read
// or write to same tables and can send deletion requests for same key
// multiple times.
Review Comment:
Comment is outdated.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java:
##########
@@ -77,20 +80,21 @@ public class DirectoryDeletingService extends
AbstractKeyDeletingService {
// Use only a single thread for DirDeletion. Multiple threads would read
// or write to same tables and can send deletion requests for same key
// multiple times.
- private static final int DIR_DELETING_CORE_POOL_SIZE = 1;
+ private static int DIR_DELETING_CORE_POOL_SIZE;
private static final int MIN_ERR_LIMIT_PER_TASK = 1000;
// Number of items(dirs/files) to be batched in an iteration.
private final long pathLimitPerTask;
private final int ratisByteLimit;
private final AtomicBoolean suspended;
private AtomicBoolean isRunningOnAOS;
+ private Set<Long> uniqueIDs = new LinkedHashSet<>();
Review Comment:
Can be `final`.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java:
##########
@@ -77,20 +80,21 @@ public class DirectoryDeletingService extends
AbstractKeyDeletingService {
// Use only a single thread for DirDeletion. Multiple threads would read
// or write to same tables and can send deletion requests for same key
// multiple times.
- private static final int DIR_DELETING_CORE_POOL_SIZE = 1;
+ private static int DIR_DELETING_CORE_POOL_SIZE;
Review Comment:
Variable should not be `static`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
