dnskr commented on code in PR #9:
URL: https://github.com/apache/ozone-helm-charts/pull/9#discussion_r1817838126


##########
charts/ozone/templates/datanode/datanode-statefulset.yaml:
##########
@@ -92,15 +92,29 @@ spec:
           projected:
             sources:
               - configMap:
-                  name: {{ .Release.Name }}
+                  name: {{ .Release.Name }}-ozone
               {{- with .Values.configuration.filesFrom }}
-                {{- tpl (toYaml .) $ | nindent 8 }}
+                {{- tpl (toYaml .) $ | nindent 14 }}
               {{- end }}
-        {{- if .Values.datanode.persistence.enabled }}
-        - name: data
-          persistentVolumeClaim:
-            claimName: {{ .Values.datanode.persistence.existingClaim | default 
(printf "%s-%s" .Release.Name "datanode") }}
-        {{- else }}
-        - name: data
-          emptyDir: {}
+        {{- if not .Values.datanode.persistence.enabled }}
+        - name: {{ .Release.Name }}-datanode
+          emptyDir: { }

Review Comment:
   Could you please fix minor formatting issue?
   ```suggestion
             emptyDir: {}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to