adoroszlai commented on code in PR #7374:
URL: https://github.com/apache/ozone/pull/7374#discussion_r1821957010
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStreamWithFailures.java:
##########
@@ -266,6 +264,7 @@ void testWatchForCommitDatanodeFailure(boolean flushDelay,
boolean enablePiggyba
assertEquals(0, keyOutputStream.getStreamEntries().size());
// Written the same data twice
byte[] bytes = ArrayUtils.addAll(data1, data1);
+ cluster.restartHddsDatanode(pipeline.getNodes().get(0), true);
validateData(keyName, bytes, client.getObjectStore(), VOLUME, BUCKET);
Review Comment:
Shouldn't we restart datanodes at the end, in `finally` block? Restarting
them before validation feels like altering the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
