ayushtkn commented on PR #7390: URL: https://github.com/apache/ozone/pull/7390#issuecomment-2455520180
depends upon the use case, if we are measuring the during b/w two events then we should ideally use ``Time.monotonicNow()``, but I doubt if Instant.now() is helping much.. Regarding DayLight changes, are you sure System.currentMilliseconds() behaves differently ? <img width="682" alt="image" src="https://github.com/user-attachments/assets/51c853bf-1817-45b5-a52b-5ac5c425a283";> Both ``Instant.now()`` & ``System.currentMilliseconds`` are impacted by setTimeofday kind of operation AFAIK, I double checked as well <img width="686" alt="image" src="https://github.com/user-attachments/assets/6c037240-bc78-43cb-83a9-3c793b0ea9e6";> Was checking further, I think this might have performance penalties as well  so, if the above is true, & we need to do this then I believe we should be selective about the places, once we establish ``Instant.now()`` is better & helping in X use cases at Y places -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
