dombizita commented on code in PR #7393:
URL: https://github.com/apache/ozone/pull/7393#discussion_r1829038488
##########
hadoop-ozone/dist/src/main/compose/common/hadoop-test.sh:
##########
@@ -21,6 +21,12 @@ if [[ ${SECURITY_ENABLED} == "true" ]]; then
fi
export
COMPOSE_FILE="${COMPOSE_FILE:-docker-compose.yaml}":../common/${extra_compose_file}
+# need temp variables because maven filtering replaces only one item per line
+hadoop2_version="${hadoop2.version}"
+hadoop_version="${hadoop.version}"
+
+: ${HADOOP_TEST_VERSIONS:="apache/hadoop:${hadoop2_version}
flokkr/hadoop:3.1.2 apache/hadoop:${hadoop_version}"}
Review Comment:
I'm not sure about this, but without exporting the `HADOOP_TEST_VERSIONS`
environment variable, will we be able to override it? What does the `:` do in
the beginning of the line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
