pyttel commented on code in PR #10:
URL: https://github.com/apache/ozone-helm-charts/pull/10#discussion_r1832165614
##########
charts/ozone/templates/om/om-service-headless.yaml:
##########
@@ -28,6 +28,10 @@ spec:
ports:
- name: ui
port: {{ .Values.om.service.port }}
+ {{- if gt (int .Values.om.replicas) 1 }}
+ - name: ratis
+ port: 9872
+ {{- end }}
Review Comment:
> If the number of OM pods are manually modified by kubectl scale then this
port will perhaps never be exposed. We should think if there is a downside to
always exposing the port.
Great point! I hadn't considered that scenario. What could be the downside
of exposing the port within an internal Kubernetes network? Perhaps we can use
a Helm lookup mechanism to check the current replica count as an alternative,
but the simplest approach is to always expose the port.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
