slfan1989 commented on code in PR #7008: URL: https://github.com/apache/ozone/pull/7008#discussion_r1832432181
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/ContainerSafeModeRule.java: ########## @@ -50,10 +58,15 @@ public class ContainerSafeModeRule extends // Required cutoff % for containers with at least 1 reported replica. private double safeModeCutoff; // Containers read from scm db (excluding containers in ALLOCATED state). - private Map<Long, ContainerInfo> containerMap; - private double maxContainer; - - private AtomicLong containerWithMinReplicas = new AtomicLong(0); + private Set<Long> reportedContainerIDSet = new HashSet<>(); + private Map<Long, ContainerInfo> ratisContainerMap; Review Comment: This suggestion is also very reasonable. I’ve been using `ContainerInfo` solely to retrieve the minimum replica count of the container. I can optimize `ratisContainerMap` and `ecContainerMap` so that these two variables only store the mapping between `ContainerID` and its corresponding minimum replica count. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
