smengcl commented on code in PR #33:
URL:
https://github.com/apache/ozone-docker-runner/pull/33#discussion_r1833411962
##########
.github/workflows/build-and-tag.yaml:
##########
@@ -33,18 +33,25 @@ jobs:
if: ${{ github.ref_type == 'tag' }}
runs-on: ubuntu-latest
env:
+ DOCKERHUB_USER: ${{ secrets.DOCKERHUB_USER }}
IMAGE_ID: ${{ needs.build.outputs.image-id }}
+ REGISTRIES: ghcr.io # docker.io is appended dynamically
steps:
- name: Generate tags
uses: docker/metadata-action@8e5442c4ef9f78752691e2d8f8d19755c6f78e81
with:
images: |
- ghcr.io/${{ github.repository_owner }}/ozone-runner
+ ${{ github.repository_owner }}/ozone-runner
tags: |
type=ref,event=tag
flavor: |
latest=false
+ - name: Add Docker Hub to targets
+ if: ${{ env.DOCKERHUB_USER }}
+ run: |
+ echo "REGISTRIES=${{ env.REGISTRIES}} docker.io" >> $GITHUB_ENV
Review Comment:
nit
```suggestion
echo "REGISTRIES=${{ env.REGISTRIES }} docker.io" >> $GITHUB_ENV
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
