jojochuang commented on code in PR #7189:
URL: https://github.com/apache/ozone/pull/7189#discussion_r1834798247
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java:
##########
@@ -178,6 +178,15 @@ public enum ChecksumCombineMode {
tags = { ConfigTag.CLIENT, ConfigTag.CRYPTO_COMPLIANCE })
private int bytesPerChecksum = 16 * 1024;
+ // Client-side block chunk checksum cache config
+ // TODO: Re-evaluate if this need to be exposed to end-users at all, e.g. to
avoid confusion.
+ @Config(key = "chunk.checksum.cache.enabled",
Review Comment:
IMO this should be the default behavior if incremental chunk list option is
enabled.
Ok to simply drop this configuration property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]