sodonnel commented on code in PR #7410:
URL: https://github.com/apache/ozone/pull/7410#discussion_r1834815319
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconUtils.java:
##########
@@ -326,16 +353,19 @@ public static String constructFullPath(String keyName,
long initialParentId, Str
if (nsSummary == null) {
log.warn("NSSummary tree is currently being rebuilt or the directory
could be in the progress of " +
"deletion, returning empty string for path construction.");
- return "";
+ return fullPath;
Review Comment:
The test caught a real problem I think. I had appended the file onto the
empty prefix in the `constructFullPath()` wrapper method, which was easy fixed.
But then I realised the NsSummary rebuild could appear part way through walking
the hierarchy, so reset the SB to zero and return now too. That passes the
tests locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
