adoroszlai opened a new pull request, #7421:
URL: https://github.com/apache/ozone/pull/7421

   ## What changes were proposed in this pull request?
   
   Avoid false negative 
([failing](https://github.com/jojochuang/ozone/actions/runs/11388335221/job/31686275738#step:5:19),
 but reported as passing) _acceptance (s3a)_ check if Hadoop cannot be 
downloaded.
   
   ```
   tar: Child returned status 1
   tar: Error is not recoverable: exiting now
   ```
   
   Abort the check in this case.
   
   https://issues.apache.org/jira/browse/HDDS-11664
   
   ## How was this patch tested?
   
   Temporarily changed Hadoop version to non-existent:
   
   ```diff
   diff --git pom.xml pom.xml
   index 9d48f929f6..1ad7cf2939 100644
   --- pom.xml
   +++ pom.xml
   @@ -67,7 +67,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xs
        
<project.build.outputTimestamp>2023-01-01T00:00:00Z</project.build.outputTimestamp>
    
        <hadoop2.version>2.10.2</hadoop2.version>
   -    <hadoop.version>3.3.6</hadoop.version>
   +    <hadoop.version>3.3.9</hadoop.version>
    
        <!-- version for hdds/ozone components -->
        <hdds.version>${ozone.version}</hdds.version>
   ```
   
   And ran the check locally:
   
   ```bash
   $ OZONE_ACCEPTANCE_SUITE=s3a ./hadoop-ozone/dev-support/checks/acceptance.sh
   Downloading Hadoop from 
https://archive.apache.org/dist/hadoop/common/hadoop-3.3.9/hadoop-3.3.9-src.tar.gz
   curl: (22) The requested URL returned error: 404
   
   $ echo $?
   1
   
   $ cat target/acceptance/summary.txt 
   Failed to download Hadoop 3.3.9
   ```
   
   CI:
   https://github.com/adoroszlai/ozone/actions/runs/11783671867/job/32821950391


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to