adoroszlai opened a new pull request, #7428: URL: https://github.com/apache/ozone/pull/7428
## What changes were proposed in this pull request? SpotBugs spends quite some time (~2.5 minutes) analyzing protobuf generated classes in _basic (findbugs)_ check ([example](https://github.com/apache/ozone/actions/runs/11812304304/job/32907294585#step:7:494): ``` 2024-11-13T07:07:13.4457877Z [INFO] --- spotbugs-maven-plugin:3.1.12.2:spotbugs (default-cli) @ hdds-interface-client --- 2024-11-13T07:07:14.2753914Z [INFO] Fork Value is true 2024-11-13T07:07:44.5920143Z [INFO] Done SpotBugs Analysis.... ... 2024-11-13T07:07:48.7132408Z [INFO] --- spotbugs-maven-plugin:3.1.12.2:spotbugs (default-cli) @ hdds-interface-admin --- 2024-11-13T07:07:48.7224599Z [INFO] Fork Value is true 2024-11-13T07:08:07.8785130Z [INFO] Done SpotBugs Analysis.... ... 2024-11-13T07:08:11.9305598Z [INFO] --- spotbugs-maven-plugin:3.1.12.2:spotbugs (default-cli) @ hdds-interface-server --- 2024-11-13T07:08:11.9403330Z [INFO] Fork Value is true 2024-11-13T07:08:33.4146294Z [INFO] Done SpotBugs Analysis.... ... 2024-11-13T07:12:25.4418247Z [INFO] --- spotbugs-maven-plugin:3.1.12.2:spotbugs (default-cli) @ ozone-interface-client --- 2024-11-13T07:12:26.0084460Z [INFO] Fork Value is true 2024-11-13T07:13:39.6522625Z [INFO] Done SpotBugs Analysis.... ... 2024-11-13T07:19:28.6163995Z [INFO] Total time: 12:46 min ``` Since these modules do not have any Java sources, only code generated from protobuf files, we can skip SpotBugs analysis. https://issues.apache.org/jira/browse/HDDS-11692 ## How was this patch tested? Verified that SpotBugs indeed skips these modules: ``` $ ./hadoop-ozone/dev-support/checks/findbugs.sh ... [INFO] --- spotbugs-maven-plugin:3.1.12.2:spotbugs (default-cli) @ hdds-interface-client --- [INFO] ... [INFO] --- spotbugs-maven-plugin:3.1.12.2:spotbugs (default-cli) @ hdds-interface-admin --- [INFO] ... [INFO] --- spotbugs-maven-plugin:3.1.12.2:spotbugs (default-cli) @ hdds-interface-server --- [INFO] ... [INFO] --- spotbugs-maven-plugin:3.1.12.2:spotbugs (default-cli) @ ozone-interface-client --- [INFO] ``` CI: https://github.com/adoroszlai/ozone/actions/runs/11815271941/job/32916101846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
