adoroszlai commented on PR #7394:
URL: https://github.com/apache/ozone/pull/7394#issuecomment-2476900544

   BTW, here is a simple update for the `xcompat` test to cover delegation 
tokens, would be nice to add it to the patch.
   
   ```diff
   diff --git hadoop-ozone/dist/src/main/smoketest/compatibility/read.robot 
hadoop-ozone/dist/src/main/smoketest/compatibility/read.robot
   index e56465bb8b..00f5408bc6 100644
   --- hadoop-ozone/dist/src/main/smoketest/compatibility/read.robot
   +++ hadoop-ozone/dist/src/main/smoketest/compatibility/read.robot
   @@ -46,3 +46,8 @@ FSO Bucket Can Be Read
        Execute    ozone fs -get 
ofs://om/vol1/fso-bucket-${SUFFIX}/dir/subdir/file ${TEMP_DIR}/
        Execute    diff -q ${TESTFILE} ${TEMP_DIR}/file
        [teardown]    Execute    rm -f ${TEMP_DIR}/file
   +
   +Delegation Token Can Be Renewed
   +    Execute    ozone sh key get -f /vol1/bucket1/token-${SUFFIX} 
${TEMP_DIR}/token
   +    Execute    ozone sh token renew --token ${TEMP_DIR}/token
   +    [teardown]    Execute    rm -f ${TEMP_DIR}/token
   diff --git hadoop-ozone/dist/src/main/smoketest/compatibility/write.robot 
hadoop-ozone/dist/src/main/smoketest/compatibility/write.robot
   index a44901a99a..0453f00c0d 100644
   --- hadoop-ozone/dist/src/main/smoketest/compatibility/write.robot
   +++ hadoop-ozone/dist/src/main/smoketest/compatibility/write.robot
   @@ -40,3 +40,8 @@ FSO Bucket Can Be Created and Used
        Execute    ozone sh bucket create --layout FILE_SYSTEM_OPTIMIZED 
/vol1/fso-bucket-${SUFFIX}
        Execute    ozone fs -mkdir -p 
ofs://om/vol1/fso-bucket-${SUFFIX}/dir/subdir
        Execute    ozone fs -put ${TESTFILE} 
ofs://om/vol1/fso-bucket-${SUFFIX}/dir/subdir/file
   +
   +Delegation Token Can Be Obtained
   +    [setup]    Execute    rm -f ${TEMP_DIR}/token
   +    Execute    ozone sh token get --token ${TEMP_DIR}/token
   +    Execute    ozone sh key put /vol1/bucket1/token-${SUFFIX} 
${TEMP_DIR}/token
   ```
   
   I've run this with `old_versions="1.4.0"` only, assuming all prior releases 
have the same behavior for tokens.  Both `token get` and `token renew` works 
well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to