errose28 commented on PR #7436: URL: https://github.com/apache/ozone/pull/7436#issuecomment-2479544370
> Also recording the last scan key will cause it to skip the newer entries which alphabetically (sorted order) appear before the last scan key causing many keys to remain undeleted. +1. This also adds coupling to internal RocksDB behavior that may be optimized or irrelevant in later releases. Since the change is not without drawbacks it would be good to run a micro benchmark to quantify the speedup. A simple junit test that generates large amounts of delete entries and times how long the new vs old implementation takes to clear them out would probably suffice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
