adoroszlai commented on code in PR #7434:
URL: https://github.com/apache/ozone/pull/7434#discussion_r1844178527
##########
dev-support/ci/selective_ci_checks.bats:
##########
@@ -190,14 +190,14 @@ load bats-assert/load.bash
}
@test "native test in other module" {
- run dev-support/ci/selective_ci_checks.sh 822c0dee1a
+ run dev-support/ci/selective_ci_checks.sh
3115158830483c527fb978e1edc15473d81191d2
Review Comment:
Thanks. I was going to suggest exactly that.
Fixing the test is difficult, because we need the git tree as of the commit,
but need `dev-support/ci` in its current state (because outputs also change
sometimes, and the test should validate current outputs). So we'd need to
store `dev-support/ci` temporarily, `git checkout` old state, overwrite old
`dev-support/ci` (which may even be absent), then restore after the test. Not
cheap and potentially dangerous for dev local changes (when run locally, not in
CI).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
