nandakumar131 commented on code in PR #7426:
URL: https://github.com/apache/ozone/pull/7426#discussion_r1844889380


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/BlockDeletingService.java:
##########
@@ -127,12 +128,14 @@ public Long getNumBlocksToDelete() {
   public BackgroundTaskQueue getTasks() {
     BackgroundTaskQueue queue = new BackgroundTaskQueue();
 
+    metrics.resetLastIterationCounts();

Review Comment:
   If someone queries the metrics after the `resetLastIterationCounts` is done 
and before we populate all the counters again, won't we get inconsistent result?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to