xichen01 commented on code in PR #6655:
URL: https://github.com/apache/ozone/pull/6655#discussion_r1844965891
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:
##########
@@ -448,11 +449,15 @@ public HddsProtos.DatanodeDetailsProto
getProtoBufMessage() {
}
public HddsProtos.DatanodeDetailsProto toProto(int clientVersion) {
- return toProtoBuilder(clientVersion).build();
+ return toProtoBuilder(clientVersion, Collections.emptySet()).build();
+ }
+
+ public HddsProtos.DatanodeDetailsProto toProto(int clientVersion,
Set<Port.Name> requiredPorts) {
+ return toProtoBuilder(clientVersion, requiredPorts).build();
}
public HddsProtos.DatanodeDetailsProto.Builder toProtoBuilder(
- int clientVersion) {
+ int clientVersion, Set<Port.Name> requiredPorts) {
Review Comment:
`requiredPorts` does tend to be misleading I have changed it to
`filterPorts`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
