adoroszlai commented on code in PR #7440:
URL: https://github.com/apache/ozone/pull/7440#discussion_r1846081635
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -2311,6 +2311,22 @@ public List<OzoneFileStatus> listStatus(String
volumeName, String bucketName,
allowPartialPrefixes);
}
+ @Override
+ public List<OzoneFileStatusLight> listStatusLight(String volumeName, String
bucketName, String keyName,
+ boolean recursive, String startKey, long numEntries) throws IOException {
+ OmKeyArgs keyArgs = prepareOmKeyArgs(volumeName, bucketName, keyName);
+ if (omVersion.compareTo(OzoneManagerVersion.LIGHTWEIGHT_LIST_STATUS) >= 0)
{
+ return ozoneManagerClient.listStatusLight(keyArgs, recursive, startKey,
+ numEntries);
Review Comment:
> We have implemented the same thing even for listStatus API. It would be
better to have some uniformity there.
For `listStatus` methods, new method with additional parameter was
introduced later:
```
2019-05-21 14:47:48 +0530 968) List<OzoneFileStatus> listStatus(OmKeyArgs
keyArgs, boolean recursive,
2019-05-21 14:47:48 +0530 969) String startKey, long numEntries)
throws IOException;
2022-06-03 08:41:29 +0530 984) List<OzoneFileStatus> listStatus(OmKeyArgs
keyArgs, boolean recursive,
2022-06-03 08:41:29 +0530 985) String
startKey, long numEntries,
2022-06-03 08:41:29 +0530 986) boolean
allowPartialPrefixes)
```
Since the existing `listStatusLight` covers both cases, overloading the
method is not necessary now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
