swamirishi commented on code in PR #7418:
URL: https://github.com/apache/ozone/pull/7418#discussion_r1849379502
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java:
##########
@@ -330,7 +330,8 @@ public List<DatanodeDetails> getNodesInOrder() {
}
void reportDatanode(DatanodeDetails dn) throws IOException {
- if (nodeStatus.get(dn) == null) {
+ if (dn == null || (nodeStatus.get(dn) == null
Review Comment:
This is the case where a DN has gone down and has come back up with a
different dnId. In such a case the DN could still be a part of an existing
pipeline. The registeration of this dn on SCM should not fail since it is the
same node. This is a very dumb way to work around
https://issues.apache.org/jira/browse/HDDS-11670. Eventually these pipeline
would get closed once the datanode proposes to close the existing pipeline on
the next in-flight write or SCM will close it automatically marking the older
datanodeId as dead and closing all the pipelines which contains the node with
the old datanode id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
