ashishkumar50 commented on code in PR #7460:
URL: https://github.com/apache/ozone/pull/7460#discussion_r1849924720


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java:
##########
@@ -137,6 +137,10 @@ public List<DeletedBlocksTransaction> 
getFailedTransactions(int count,
             }
           }
         } else {
+          iter.seek(startTxId);
+          if (iter.hasNext()) {
+            iter.next();

Review Comment:
   The problem is if we don't do next here then `nextTx` still points to old 
location. And when we do 
[getvalue](https://github.com/apache/ozone/blob/6b40003bb251a4ad699f38e6cc3adc6a354adaed/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java#L141)
 it returns the old value instead the value where we seek.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to