Ethan Rose created HDDS-11756:
---------------------------------
Summary: Trigger test failure if new scanner failure types are
added without tests
Key: HDDS-11756
URL: https://issues.apache.org/jira/browse/HDDS-11756
Project: Apache Ozone
Issue Type: Sub-task
Reporter: Ethan Rose
The
[FailureType|https://github.com/apache/ozone/blob/81a2ee6c972975f676ca5ca4fa7b1ba1b86fd003/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerScanError.java#L30]
enum is used to indicate what type of issue the scanner saw.
[TestContainerCorruptions|https://github.com/apache/ozone/blob/8ff233517d9526ff9377e776ad0c64d10f0554ab/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestContainerCorruptions.java#L49]
also provides an enum for injecting different types of failures into tests.
The two are separate since some {{FailureTypes}} may be hit with multiple
paths, each identified by a unique entry in {{TestContainerCorruptions}}
As suggested in [this
comment|https://github.com/apache/ozone/pull/7396#issuecomment-2484214305], it
would be good to have a way to trigger a test failure if a new {{FailureType}}
is added (expanding the functionality of the scanner) but no corresponding test
is added. This may mean making the two enums more tightly coupled.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
