errose28 commented on code in PR #7451:
URL: https://github.com/apache/ozone/pull/7451#discussion_r1850859757
##########
hadoop-ozone/dist/src/main/compose/xcompat/test.sh:
##########
@@ -74,29 +75,21 @@ _read() {
compatibility/read.robot
}
-test_bucket_encryption() {
- _kinit
- execute_robot_test ${container} -N
"xcompat-cluster-${cluster_version}-client-${client_version}" -v
SUFFIX:${client_version} security/bucket-encryption.robot
Review Comment:
Can we delete this robot file now?
##########
hadoop-ozone/dist/src/main/compose/xcompat/test.sh:
##########
@@ -50,6 +50,7 @@ _kinit() {
}
_init() {
+ container=scm
Review Comment:
Why does this method need to explicitly specify this, while other's leave
the container variable up to the caller?
##########
hadoop-ozone/dist/src/main/smoketest/compatibility/write.robot:
##########
@@ -24,9 +24,16 @@ Suite Setup Create Local Test File
*** Variables ***
${SUFFIX} ${EMPTY}
+${KEY_NAME} key1
Review Comment:
nit. Can we rename this to ENC_KEY or something similar? Out of context it
looks like this is the name that will be used for the actual data key written.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
