szetszwo commented on code in PR #7466:
URL: https://github.com/apache/ozone/pull/7466#discussion_r1852567112
##########
hadoop-ozone/dist/src/main/license/src/licenses/IMPORTANT.md:
##########
@@ -14,8 +14,5 @@
# Important
-The files from this directory are not copied by automatically to the source
distribution package.
Review Comment:
Let's keep the sentence and refer to `ozone-src.xml`.
```
The files from this directory are copied automatically to the source
distribution package
via the `hadoop-ozone/dist/src/main/assemblies/ozone-src.xml` file.
```
##########
hadoop-ozone/dist/src/main/assemblies/ozone-src.xml:
##########
@@ -32,28 +32,22 @@
<source>NOTICE.txt</source>
<outputDirectory>/</outputDirectory>
</file>
- <file>
-
<source>hadoop-ozone/dist/src/main/license/src/licenses/LICENSE-angular-nvd3.txt</source>
- <outputDirectory>/licenses</outputDirectory>
- </file>
- <file>
-
<source>hadoop-ozone/dist/src/main/license/src/licenses/LICENSE-angular.txt</source>
- <outputDirectory>/licenses</outputDirectory>
- </file>
- <file>
-
<source>hadoop-ozone/dist/src/main/license/src/licenses/LICENSE-d3.txt</source>
- <outputDirectory>/licenses</outputDirectory>
- </file>
- <file>
-
<source>hadoop-ozone/dist/src/main/license/src/licenses/LICENSE-nvd3.txt</source>
- <outputDirectory>/licenses</outputDirectory>
- </file>
- <file>
-
<source>hadoop-ozone/dist/src/main/license/src/licenses/LICENSE-jquery.txt</source>
- <outputDirectory>/licenses</outputDirectory>
- </file>
</files>
<fileSets>
+ <fileSet>
+ <directory>hadoop-ozone/dist/src/main/license/src/licenses</directory>
+ <outputDirectory>/licenses</outputDirectory>
+ <includes>
+ <include>*.txt</include>
Review Comment:
Let's use `LICENSE-*.txt`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
