yuzelin commented on code in PR #608:
URL: https://github.com/apache/incubator-paimon/pull/608#discussion_r1140123542


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/table/AbstractFileStoreTable.java:
##########
@@ -179,4 +188,25 @@ public TableCommitImpl newCommit(String commitUser) {
                 options().writeOnly() ? null : store().newExpire(),
                 options().writeOnly() ? null : 
store().newPartitionExpire(commitUser));
     }
+
+    private void tryTimeTravel(Options options) {
+        if (options.contains(CoreOptions.TIME_TRAVEL_SNAPSHOT_ID)) {

Review Comment:
   I misunderstood this question. Should use `scan.from-snapshot` here. 
   And I think the table should always use dynamic option as target because 
when we call `#copy` and pass new target, it means do time travel.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to