JingsongLi commented on code in PR #584:
URL: https://github.com/apache/incubator-paimon/pull/584#discussion_r1146071481
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/source/DataTableSource.java:
##########
@@ -191,22 +195,54 @@ public ScanRuntimeProvider
getScanRuntimeProvider(ScanContext scanContext) {
}
}
+ List<Split> splits = null;
+ DataTableScan.DataFilePlan dataFilePlan = table.newScan().plan();
+ // TODO: we will refactor this after
https://github.com/apache/incubator-paimon/issues/638
+ // finished.
+ if (null != dataFilePlan) {
+ splits = dataFilePlan.splits();
Review Comment:
There is also a cost to generating splits at the compile stage, it causes
the generated topology to become large if there are a lot of splits.
Can we just generate splits when necessary and keep the original process
without inference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
