[GitHub] [incubator-paimon] legendtkl commented on pull request #714: [core] support JDK 11

Tue, 28 Mar 2023 08:39:43 -0700 


legendtkl commented on PR #714:
URL: https://github.com/apache/incubator-paimon/pull/714#issuecomment-1487147374

   > Thanks @legendtkl for the contribution! I am very pleased to be able to 
officially announce support for JDK11! But one thing is that still JDK8 is 
currently the main force, as mentioned by the partners of the review above.
   > 
   > Another thing is that I don't really want to cause too many tests, is it 
possible to provide the ability to test with JDK11, but by default it needs to 
be enabled manually?
   
   Hi, @JingsongLi , I have add the github action based PR's comment and update 
the workflows.
   
   The JDK 11 workflows will not run by default. When we comment '/jdk11' in 
the PR, the workflow will start to run. ***But this feature will work only when 
the workflows files is on the default branch, namely master.*** That means, we 
can't verify this in this PR, and it will work only when this PR is merged.
   
   I have tested it manually on my branch. When I comment '/jdk11', the jdk11 
workflows start running, we can see it in the `Action` tab.
   
   <img width="438" alt="image" 
src="https://user-images.githubusercontent.com/2370761/228291415-18d09fc4-9293-42c6-b9b1-03427818181a.png";>
   
   
   <img width="1822" alt="image" 
src="https://user-images.githubusercontent.com/2370761/228291225-de784154-4191-4d73-acca-55ce57f96773.png";>
   
   Ref: https://github.com/orgs/community/discussions/25389
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to