SteNicholas commented on code in PR #812:
URL: https://github.com/apache/incubator-paimon/pull/812#discussion_r1159524354
##########
paimon-core/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -568,6 +568,23 @@ public class CoreOptions implements Serializable {
"Only used to force TableScan to construct
'ContinuousCompactorStartingScanner' and "
+ "'ContinuousCompactorFollowUpScanner'
for dedicated streaming compaction job.");
+ public static final ConfigOption<StreamReadType> LOG_READ_FROM =
+ key("log.read-from")
+ .enumType(StreamReadType.class)
+ .noDefaultValue()
+ .withDescription(
+ Description.builder()
+ .text("Read the store type of the paimon
table.")
+ .linebreak()
+ .linebreak()
+ .text("Possible values:")
+ .linebreak()
+ .list(text("\"file\": Will read from the
file store"))
Review Comment:
Use the `StreamReadType.FILE.getValue()`.
##########
paimon-core/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -568,6 +568,23 @@ public class CoreOptions implements Serializable {
"Only used to force TableScan to construct
'ContinuousCompactorStartingScanner' and "
+ "'ContinuousCompactorFollowUpScanner'
for dedicated streaming compaction job.");
+ public static final ConfigOption<StreamReadType> LOG_READ_FROM =
+ key("log.read-from")
+ .enumType(StreamReadType.class)
+ .noDefaultValue()
+ .withDescription(
+ Description.builder()
+ .text("Read the store type of the paimon
table.")
+ .linebreak()
+ .linebreak()
+ .text("Possible values:")
+ .linebreak()
+ .list(text("\"file\": Will read from the
file store"))
+ .list(
+ text(
+ "\"log-system\":Will read
from the file store, the user must configure log.system"))
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
