[GitHub] [incubator-paimon] SteNicholas commented on a diff in pull request #812: [core]Add streaming read from option (#778)

[via GitHub]

SteNicholas commented on code in PR #812:
URL: https://github.com/apache/incubator-paimon/pull/812#discussion_r1161660269


##########
paimon-core/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -1054,6 +1079,49 @@ public static FileFormatType fromValue(String value) {
         }
     }
 
+    /** Specifies the type for streaming read. */
+    public enum StreamingReadMode implements DescribedEnum {
+        LOG("log", "Read from log system such as kafka."),
+        FILE("file", "Read from file store.");

Review Comment:
   ```suggestion
           FILE("file", "Reads from the file store.");
   ```



##########
paimon-core/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -1054,6 +1079,49 @@ public static FileFormatType fromValue(String value) {
         }
     }
 
+    /** Specifies the type for streaming read. */
+    public enum StreamingReadMode implements DescribedEnum {
+        LOG("log", "Read from log system such as kafka."),

Review Comment:
   ```suggestion
           LOG("log", "Reads from the log store."),
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org