JingsongLi commented on code in PR #1021:
URL: https://github.com/apache/incubator-paimon/pull/1021#discussion_r1176565882
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlSyncDatabaseAction.java:
##########
@@ -106,16 +116,49 @@ public class MySqlSyncDatabaseAction implements Action {
boolean ignoreIncompatible,
Map<String, String> catalogConfig,
Map<String, String> tableConfig) {
+ this(
+ mySqlConfig,
+ warehouse,
+ database,
+ ignoreIncompatible,
+ null,
+ null,
+ null,
+ null,
+ catalogConfig,
+ tableConfig);
+ }
+
+ MySqlSyncDatabaseAction(
+ Map<String, String> mySqlConfig,
+ String warehouse,
+ String database,
+ boolean ignoreIncompatible,
+ @Nullable String tablePrefix,
+ @Nullable String tableSuffix,
+ @Nullable String includingTable,
+ @Nullable String excludingTable,
+ Map<String, String> catalogConfig,
+ Map<String, String> tableConfig) {
this.mySqlConfig = Configuration.fromMap(mySqlConfig);
this.warehouse = warehouse;
this.database = database;
this.ignoreIncompatible = ignoreIncompatible;
+ this.tablePrefix = tablePrefix == null ? "" : tablePrefix;
+ this.tableSuffix = tableSuffix == null ? "" : tableSuffix;
+
+ checkArgument(
+ includingTable == null || excludingTable == null,
+ "Cannot specify including tables and excluding tables at the
same time.");
Review Comment:
Maybe we can support both includingTable and excludingTable, it looks not
complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
