JingsongLi commented on code in PR #1031:
URL: https://github.com/apache/incubator-paimon/pull/1031#discussion_r1177569206
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlActionUtils.java:
##########
@@ -202,4 +205,37 @@ static MySqlSource<String> buildMySqlSource(Configuration
mySqlConfig) {
new JsonDebeziumDeserializationSchema(true,
customConverterConfigs);
return
sourceBuilder.deserializer(schema).includeSchemaChanges(true).build();
}
+
+ private static void validateMySqlConfig(Configuration mySqlConfig) {
+ checkArgument(
+ mySqlConfig.get(MySqlSourceOptions.HOSTNAME) != null
Review Comment:
`mySqlConfig.contains(MySqlSourceOptions.HOSTNAME)`
Just check `contains` is OK, if it is a empty string, detailed message will
be reported in mysql client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
