yuzelin commented on code in PR #1069:
URL: https://github.com/apache/incubator-paimon/pull/1069#discussion_r1185896481
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/CompactAction.java:
##########
@@ -74,6 +78,13 @@ public CompactAction withPartitions(List<Map<String,
String>> partitions) {
return this;
}
+ static Options getCatalogOptions(MultipleParameterTool params) {
+ Map<String, String> catalogConfig = getConfigMap(params,
"catalog-conf");
Review Comment:
`getConfigMap` may return null, so we need to check nullability.
Can we do it like this in `create`:
```
Tuple3<String, String, String> tablePath = getTablePath(params);
if (tablePath == null) {
return Optional.empty();
}
```
And then this method is not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
